activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #:
Date Sat, 23 Jun 2018 22:56:40 GMT
Github user michaelandrepearce commented on the pull request:

    https://github.com/apache/activemq-artemis/commit/576cf7e73ddabdcbd67ea24a9111889d6c4c7e48#commitcomment-29474478
  
    In artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java:
    In artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
on line 515:
    Theres an issue in this logic as if the older methods are invoked it will clear the user
as user passed by them in delegatiom is null. 
    
    I see two alternatives to avoid this issue.
    Either 
    
    this method could do the user bit and then pass to the method that existed before from
this new one.
    
    Or
    
    If null is passed in you dont update the user, its only updated if its not null 


---

Mime
View raw message