activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2152: ARTEMIS-1924 small tweaks on HeartBeat ...
Date Wed, 20 Jun 2018 15:15:59 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2152#discussion_r196822722
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
---
    @@ -137,18 +139,21 @@ public void inspectOpenedResource(Connection connection) {
        }
     
        public static void main(String[] arg) {
    -      if (arg.length > 0 && arg[0].equals("testConnectionReset")) {
    +      if (arg.length > 0 && arg[0].startsWith("testCloseConsumerOnConnectionReset"))
{
    --- End diff --
    
    I was going to do that, but then the argument was: testCloseConsumerOnConnectionReset[useOverride=true]()

    
    The test is using parameters.. which I didn't like as the name of the queue... 
    
    I would prefer leaving it as is... 


---

Mime
View raw message