activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gemmellr <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2149: ARTEMIS-1924 Test consumer cleanup afte...
Date Wed, 20 Jun 2018 14:55:24 GMT
Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2149#discussion_r196814636
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
---
    @@ -80,4 +88,68 @@ public void inspectOpenedResource(Connection connection) {
           connection.close();
        }
     
    +   private static final String QUEUE_NAME = "queue://testHeartless";
    +
    +   // This test is validating a scenario where the client will leave with connection
reset
    +   // This is done by setting soLinger=0 on the socket, which will make the system to
issue a connection.reset instead of sending a
    +   // disconnect.
    +   @Test(timeout = 60000)
    +   public void testCloseConsumerOnConnectionReset() throws Exception {
    --- End diff --
    
    To me it seems that the broker behaviour should essentially be the same here regardless
whether idle-timeout is enabled or not, i.e a connection explicitly goes away, the broker
cleans up a consumer on it, and its not really testing idle-timeout behaviour or the lack
of it, making it feels a bit odd it being in here.


---

Mime
View raw message