From dev-return-65583-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Wed May 16 13:23:50 2018
Return-Path: <dev-return-65583-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 8CDA1180669
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 16 May 2018 13:23:49 +0200 (CEST)
Received: (qmail 68589 invoked by uid 500); 16 May 2018 11:23:48 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 68569 invoked by uid 99); 16 May 2018 11:23:47 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 May 2018 11:23:47 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 9BF02E09EC; Wed, 16 May 2018 11:23:47 +0000 (UTC)
From: RaiSaurabh <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-2089-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-2089-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #2089: ARTEMIS-1866: Make wait time for reply ...
Content-Type: text/plain
Message-Id: <20180516112347.9BF02E09EC@git1-us-west.apache.org>
Date: Wed, 16 May 2018 11:23:47 +0000 (UTC)

Github user RaiSaurabh commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2089#discussion_r188589506
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/SharedNothingBackupQuorum.java ---
    @@ -90,6 +92,7 @@ public SharedNothingBackupQuorum(StorageManager storageManager,
           this.networkHealthCheck = networkHealthCheck;
           this.voteRetries = voteRetries;
           this.voteRetryWait = voteRetryWait;
    +      this.quorumVoteWait = quorumVoteWait;
    --- End diff --
    
    The parameter is already validated when it is picked form the broker .xml.  You can check class "FileConfigurationParser" L1322 and L1352 for validation of number greater than zero.


---