activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tabish121 <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #2106: [ARTEMIS-1885]max-consumers attribute in queue...
Date Thu, 24 May 2018 16:05:22 GMT
Github user tabish121 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2106
  
    If it is fixing something then it needs a test.  If it is not fixing something than the
JIRA description needs to be changed as it makes it sound like it is fixing something, and
probably still should have a test if it affects some broker behavior.  Regardless of all that
the JIRA and the commit message should have a more meaningful description of what is going
on as it they are both so sparse as to make it utterly impossible for the casual observer
to figure out what they are for.  
    
    Specifically if there is no AMQP issue here then the message and the JIRA should not imply
there is. 


---

Mime
View raw message