activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2103: ARTEMIS-1872 Improving Security Checks ...
Date Thu, 24 May 2018 00:48:22 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2103#discussion_r190437791
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/SecureConfigurationTest.java
---
    @@ -177,8 +161,31 @@ private void internal_testSecureDurableSubscriber(ConnectionFactory
connectionFa
           } catch (JMSSecurityException j) {
              //Expected exception
           }
    +
    +      Connection connection = null;
    +
    +      try {
    +         connection = connectionFactory.createConnection();
    +         Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
    +
    +         try {
    +            session.createTemporaryQueue();
    +            Assert.fail("Security exception expected, but did not occur, excepetion expected
as not permissioned to create a temporary queue");
    +         } catch (JMSSecurityException jmsse) {
    +            IntegrationTestLogger.LOGGER.info("Client should have thrown a JMSSecurityException
but only threw JMSException");
    --- End diff --
    
    This is incorrect log message, it idicates a problem when actually this is expected behaviour


---

Mime
View raw message