activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2089: ARTEMIS-1866: Make wait time for reply ...
Date Mon, 14 May 2018 13:25:47 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2089#discussion_r187945798
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ha/ReplicaPolicy.java
---
    @@ -57,6 +57,8 @@
     
        private long voteRetryWait;
     
    +   private int quorumVoteWait = ActiveMQDefaultConfiguration.getDefaultQuorumVoteWait();
    --- End diff --
    
    It would be better to just use the one provided by the constructor and declare this `final`
if is not meant to be modified anymore


---

Mime
View raw message