activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2089: ARTEMIS-1866: Make wait time for reply ...
Date Mon, 14 May 2018 13:25:47 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2089#discussion_r187950231
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/SharedNothingBackupQuorum.java
---
    @@ -297,7 +300,7 @@ private boolean isLiveDown() {
                 quorumManager.vote(quorumVote);
     
                 try {
    -               quorumVote.await(LATCH_TIMEOUT, TimeUnit.SECONDS);
    +               quorumVote.await(quorumVoteWait, TimeUnit.SECONDS);
                 } catch (InterruptedException interruption) {
                    // No-op. The best the quorum can do now is to return the latest number
it has
    --- End diff --
    
    Please add some trace logs before the `await` and on the catch scope to log that the awaut
has been interrupted


---

Mime
View raw message