From dev-return-65288-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Wed Apr 25 15:59:16 2018
Return-Path: <dev-return-65288-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 7A598180676
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 25 Apr 2018 15:59:15 +0200 (CEST)
Received: (qmail 26061 invoked by uid 500); 25 Apr 2018 13:59:14 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 26046 invoked by uid 99); 25 Apr 2018 13:59:13 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Apr 2018 13:59:13 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id A44F8DFB31; Wed, 25 Apr 2018 13:59:13 +0000 (UTC)
From: franz1981 <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-2044-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-2044-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #2044: ARTEMIS-1829 Remove deprecated plugin's...
Content-Type: text/plain
Message-Id: <20180425135913.A44F8DFB31@git1-us-west.apache.org>
Date: Wed, 25 Apr 2018 13:59:13 +0000 (UTC)

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2044#discussion_r184069060
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/plugin/impl/LoggingActiveMQServerPlugin.java ---
    @@ -595,15 +595,10 @@ public void afterDeliver(ServerConsumer consumer, MessageReference reference) th
           }
        }
     
    -   /**
    -    * A message has been expired
    -    *
    -    * @param message              The expired message
    -    * @param messageExpiryAddress The message expiry address if exists
    -    * @throws ActiveMQException
    -    */
        @Override
    -   public void messageExpired(MessageReference message, SimpleString messageExpiryAddress) throws ActiveMQException {
    --- End diff --
    
    @clebertsuconic That's just a plugin implementation and I have removed a (deprecated) method implementation that it wasn't already called into the broker code, using the right API that is called instead, makes sense?


---