From dev-return-65045-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Wed Apr 11 20:47:12 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5517618064A for ; Wed, 11 Apr 2018 20:47:12 +0200 (CEST) Received: (qmail 82173 invoked by uid 500); 11 Apr 2018 18:47:11 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 82160 invoked by uid 99); 11 Apr 2018 18:47:10 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Apr 2018 18:47:10 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8A0D4E09E8; Wed, 11 Apr 2018 18:47:10 +0000 (UTC) From: clebertsuconic To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de... Content-Type: text/plain Message-Id: <20180411184710.8A0D4E09E8@git1-us-west.apache.org> Date: Wed, 11 Apr 2018 18:47:10 +0000 (UTC) Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2010#discussion_r180859972 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -2727,7 +2731,7 @@ private Message makeCopy(final MessageReference ref, Message copy = message.copy(newID); if (copyOriginalHeaders) { - copy.referenceOriginalMessage(message, ref != null ? ref.getQueue().getName().toString() : null); + copy.referenceOriginalMessage(message, ref.getQueue().getName().toString()); --- End diff -- keep it ! :) nice one! ---