From dev-return-65043-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Wed Apr 11 20:44:32 2018
Return-Path: <dev-return-65043-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id AF72718064A
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 11 Apr 2018 20:44:31 +0200 (CEST)
Received: (qmail 72242 invoked by uid 500); 11 Apr 2018 18:44:30 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 72227 invoked by uid 99); 11 Apr 2018 18:44:30 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Apr 2018 18:44:30 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id EC54EE09E8; Wed, 11 Apr 2018 18:44:29 +0000 (UTC)
From: clebertsuconic <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-2010-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-2010-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...
Content-Type: text/plain
Message-Id: <20180411184429.EC54EE09E8@git1-us-west.apache.org>
Date: Wed, 11 Apr 2018 18:44:29 +0000 (UTC)

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2010#discussion_r180859106
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java ---
    @@ -205,7 +205,7 @@ public PageSubscriptionCounter getCounter() {
         */
        @Override
        public boolean reloadPageCompletion(PagePosition position) throws Exception {
    -      if (!pageStore.checkPageFileExists((int)position.getPageNr())) {
    +      if (pageStore != null && !pageStore.checkPageFileExists((int)position.getPageNr())) {
    --- End diff --
    
    pageStore is final.. it will never be null


---