activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2044: ARTEMIS-1829 Remove deprecated plugin's...
Date Wed, 25 Apr 2018 13:59:13 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2044#discussion_r184069060
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/plugin/impl/LoggingActiveMQServerPlugin.java
---
    @@ -595,15 +595,10 @@ public void afterDeliver(ServerConsumer consumer, MessageReference
reference) th
           }
        }
     
    -   /**
    -    * A message has been expired
    -    *
    -    * @param message              The expired message
    -    * @param messageExpiryAddress The message expiry address if exists
    -    * @throws ActiveMQException
    -    */
        @Override
    -   public void messageExpired(MessageReference message, SimpleString messageExpiryAddress)
throws ActiveMQException {
    --- End diff --
    
    @clebertsuconic That's just a plugin implementation and I have removed a (deprecated)
method implementation that it wasn't already called into the broker code, using the right
API that is called instead, makes sense?


---

Mime
View raw message