activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iweiss <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2035: [ARTEMIS-1819] Missing fields on listAl...
Date Wed, 25 Apr 2018 07:32:44 GMT
Github user iweiss commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2035#discussion_r183963414
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
---
    @@ -1849,7 +1860,9 @@ public String listSessionsAsJSON(final String connectionID) throws
Exception {
           try {
              List<ServerSession> sessions = server.getSessions(connectionID);
              for (ServerSession sess : sessions) {
    -            JsonObjectBuilder obj = JsonLoader.createObjectBuilder().add("sessionID",
sess.getName()).add("creationTime", sess.getCreationTime()).add("consumerCount", sess.getServerConsumers().size());
    +            JsonObjectBuilder obj = JsonLoader.createObjectBuilder().add("sessionID",
sess.getName())
    +               .add("creationTime", sess.getCreationTime())
    --- End diff --
    
    Sorry, but may I ask why? I think increasing legibility is a good thing.


---

Mime
View raw message