activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2035: [ARTEMIS-1819] Missing fields on listAl...
Date Sat, 21 Apr 2018 00:45:57 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2035#discussion_r183194361
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
---
    @@ -1943,11 +1958,43 @@ public String listAllConsumersAsJSON() throws Exception {
        }
     
        private JsonObject toJSONObject(ServerConsumer consumer) throws Exception {
    -      JsonObjectBuilder obj = JsonLoader.createObjectBuilder().add("consumerID", consumer.getID()).add("connectionID",
consumer.getConnectionID().toString()).add("sessionID", consumer.getSessionID()).add("queueName",
consumer.getQueue().getName().toString()).add("browseOnly", consumer.isBrowseOnly()).add("creationTime",
consumer.getCreationTime()).add("deliveringCount", consumer.getDeliveringMessages().size());
    +      JsonObjectBuilder obj = JsonLoader.createObjectBuilder().add("consumerID", consumer.getID())
    +         .add("connectionID", consumer.getConnectionID().toString())
    +         .add("sessionID", consumer.getSessionID())
    --- End diff --
    
    Please avoid reformatting like this, there's no code change here 


---

Mime
View raw message