activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #2015: ARTEMIS-1807 File-based Large Message encoding...
Date Mon, 16 Apr 2018 15:42:34 GMT
Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2015
  
    @gaohoward 
    
    > I think using mapped file will get better performance over the NIO channel read.
    
    @orpiske have some nice idea to test it for sure :P
    
    > It would be better to have a unit test with it. @clebertsuconic wdyt?
    
    @clebertsuconic @gaohoward 
    If you 2 will vote for the chunked version I will squash the 2 commits and provide a unit
test to cover this new implementation: ATM it is just using the tests related to large messages.
    
    @clebertsuconic 
    > I think so too.. but I would do it in the context of a refactoring in AMQP also
    
    That means that the same large body encoder should be reused for it as well?
    



---

Mime
View raw message