activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stanlyDoge <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...
Date Thu, 12 Apr 2018 06:34:56 GMT
Github user stanlyDoge commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2010#discussion_r180976916
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
    @@ -2727,7 +2731,7 @@ private Message makeCopy(final MessageReference ref,
           Message copy = message.copy(newID);
     
           if (copyOriginalHeaders) {
    -         copy.referenceOriginalMessage(message, ref != null ? ref.getQueue().getName().toString()
: null);
    +         copy.referenceOriginalMessage(message, ref.getQueue().getName().toString());
    --- End diff --
    
    @clebertsuconic thank you :) Can you please check again? Especially null reference logging.



---

Mime
View raw message