activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...
Date Wed, 11 Apr 2018 18:44:29 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2010#discussion_r180859106
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
    @@ -205,7 +205,7 @@ public PageSubscriptionCounter getCounter() {
         */
        @Override
        public boolean reloadPageCompletion(PagePosition position) throws Exception {
    -      if (!pageStore.checkPageFileExists((int)position.getPageNr())) {
    +      if (pageStore != null && !pageStore.checkPageFileExists((int)position.getPageNr()))
{
    --- End diff --
    
    pageStore is final.. it will never be null


---

Mime
View raw message