activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...
Date Wed, 11 Apr 2018 18:42:34 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2010#discussion_r180858486
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
---
    @@ -511,22 +511,24 @@ public void close() {
        public void transferConnection(final CoreRemotingConnection newConnection) {
           // Needs to synchronize on the connection to make sure no packets from
           // the old connection get processed after transfer has occurred
    -      synchronized (connection.getTransferLock()) {
    -         connection.removeChannel(id);
    +      if (connection != null) {
    --- End diff --
    
    same thing here.. how connection would be null?


---

Mime
View raw message