From dev-return-64369-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Sat Feb 24 02:44:03 2018
Return-Path: <dev-return-64369-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 44C27180652
	for <archive-asf-public@cust-asf.ponee.io>; Sat, 24 Feb 2018 02:44:03 +0100 (CET)
Received: (qmail 21406 invoked by uid 500); 24 Feb 2018 01:44:02 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 21391 invoked by uid 99); 24 Feb 2018 01:44:01 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Feb 2018 01:44:01 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 36CB4EB4E5; Sat, 24 Feb 2018 01:44:01 +0000 (UTC)
From: shoukunhuai <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1894-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1894-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1894: ARTEMIS-1700 Fixed deadlock in paging s...
Content-Type: text/plain
Message-Id: <20180224014401.36CB4EB4E5@git1-us-west.apache.org>
Date: Sat, 24 Feb 2018 01:44:01 +0000 (UTC)

Github user shoukunhuai commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405747
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java ---
    @@ -1488,7 +1494,13 @@ public synchronized void start() throws Exception {
     
           beforeStart();
     
    -      singleThreadExecutor = executorFactory.getExecutor();
    +      ThreadFactory tFactory = AccessController.doPrivileged(new PrivilegedAction<ThreadFactory>() {
    +         @Override
    +         public ThreadFactory run() {
    +            return new ActiveMQThreadFactory("ActiveMQ-journal-server-" + this.toString(), true, ClientSessionFactoryImpl.class.getClassLoader());
    +         }
    +      });
    +      singleThreadExecutor = Executors.newSingleThreadExecutor(tFactory);
    --- End diff --
    
    We are running 2.4.0
    See https://issues.apache.org/jira/browse/ARTEMIS-1700
    There is a artemis.log attached.


---