From dev-return-64132-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Thu Feb 8 23:40:49 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 905F818064F for ; Thu, 8 Feb 2018 23:40:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 80460160C4A; Thu, 8 Feb 2018 22:40:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BF446160C34 for ; Thu, 8 Feb 2018 23:40:48 +0100 (CET) Received: (qmail 22295 invoked by uid 500); 8 Feb 2018 22:40:47 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 22230 invoked by uid 99); 8 Feb 2018 22:40:47 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Feb 2018 22:40:47 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0F231DFC25; Thu, 8 Feb 2018 22:40:46 +0000 (UTC) From: michaelandrepearce To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis pull request #: Content-Type: text/plain Message-Id: <20180208224047.0F231DFC25@git1-us-west.apache.org> Date: Thu, 8 Feb 2018 22:40:46 +0000 (UTC) Github user michaelandrepearce commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27436215 In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/CreateSharedQueueMessage_V2.java: In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/CreateSharedQueueMessage_V2.java on line 199: Follows existing code pattern used already which your same scan picks up. Suggest if issue with this coding pattern as it pre exists you raise a separate jira to address ---