From dev-return-63859-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Thu Feb  1 09:12:23 2018
Return-Path: <dev-return-63859-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id 7847B180652
	for <archive-asf-public@eu.ponee.io>; Thu,  1 Feb 2018 09:12:23 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 67EBB160C44; Thu,  1 Feb 2018 08:12:23 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id A64E3160C26
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  1 Feb 2018 09:12:22 +0100 (CET)
Received: (qmail 37210 invoked by uid 500); 1 Feb 2018 08:12:21 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 37199 invoked by uid 99); 1 Feb 2018 08:12:20 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2018 08:12:20 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D49F0DFB8E; Thu,  1 Feb 2018 08:12:20 +0000 (UTC)
From: michaelandrepearce <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1827-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1827-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1827: Improve paged message acknowledge
Content-Type: text/plain
Message-Id: <20180201081220.D49F0DFB8E@git1-us-west.apache.org>
Date: Thu,  1 Feb 2018 08:12:20 +0000 (UTC)

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1827#discussion_r165282547
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/MessageReference.java ---
    @@ -38,6 +38,10 @@ public static MessageReference createReference(Message encode, final Queue queue
     
        Message getMessage();
     
    +   default long getMessageID() {
    --- End diff --
    
    -1 on hot path default methods on hot path aren't so good, suggest either leaving the code as was in ServerConsumerImpl with the getMessage().getMessageId or simply not make it default, and update other impl's within the code base.
    
    nudge @franz1981 


---