activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1893: NO-JIRA make MessageConsumerTest determ...
Date Fri, 23 Feb 2018 03:06:06 GMT
GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1893

    NO-JIRA make MessageConsumerTest deterministic

    The method testStopConnectionDuringOnMessage in this class was relying
    on sleep() calls for critical timing. This test fails sometimes on
    fast-tests so I modified it to use a latch and a few waitFor calls to be
    more deterministic. It also runs in a third of the time now.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis messageConsumerTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1893.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1893
    
----
commit d18cc6606d7026b9a6355e18231174b78dce7dcb
Author: Justin Bertram <jbertram@...>
Date:   2018-02-23T03:03:22Z

    NO-JIRA make MessageConsumerTest deterministic
    
    The method testStopConnectionDuringOnMessage in this class was relying
    on sleep() calls for critical timing. This test fails sometimes on
    fast-tests so I modified it to use a latch and a few waitFor calls to be
    more deterministic. It also runs in a third of the time now.

----


---

Mime
View raw message