activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tabish121 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1903: ARTEMIS-1706 - Add support for wantClie...
Date Tue, 27 Feb 2018 20:47:46 GMT
Github user tabish121 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1903#discussion_r171060932
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java
---
    @@ -468,8 +473,12 @@ public synchronized SslHandler getSslHandler(ByteBufAllocator alloc)
throws Exce
     
           engine.setUseClientMode(false);
     
    -      if (needClientAuth)
    +      if (needClientAuth) {
              engine.setNeedClientAuth(true);
    +      }
    +      if (wantClientAuth) {
    --- End diff --
    
    I would probably do this in an else as the setting would override the need option and
if someone did something silly like specify both I'd generally prefer it chose the stronger
of the two and setting want after need overrides it.  


---

Mime
View raw message