activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1887: ARTEMIS-1696 allow empty 'address' for ...
Date Thu, 22 Feb 2018 22:51:04 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1887#discussion_r170118840
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
---
    @@ -1671,7 +1671,7 @@ private void parseClusterConnectionConfiguration(final Element e,
final Configur
        private void parseGroupingHandlerConfiguration(final Element node, final Configuration
mainConfiguration) {
           String name = node.getAttribute("name");
           String type = getString(node, "type", null, Validators.NOT_NULL_OR_EMPTY);
    -      String address = getString(node, "address", null, Validators.NOT_NULL_OR_EMPTY);
    +      String address = getString(node, "address", "", Validators.NO_CHECK);
    --- End diff --
    
    why "" for default not Null now you're removing the NOT NULL OR EMPTY check?


---

Mime
View raw message