activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nlippke <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1822: ARTEMIS-1653 Allow database tables to b...
Date Fri, 16 Feb 2018 09:30:21 GMT
Github user nlippke commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1822#discussion_r168707901
  
    --- Diff: artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcLeaseLockTest.java
---
    @@ -33,13 +35,31 @@
     import org.junit.Assert;
     import org.junit.Before;
     import org.junit.Test;
    +import org.junit.runner.RunWith;
    +import org.junit.runners.Parameterized;
    +import org.junit.runners.Parameterized.Parameter;
     
    +@RunWith(Parameterized.class)
     public class JdbcLeaseLockTest extends ActiveMQTestBase {
     
        private JdbcSharedStateManager jdbcSharedStateManager;
        private DatabaseStorageConfiguration dbConf;
        private SQLProvider sqlProvider;
     
    +   @Parameterized.Parameters(name = "create_tables_prior_test")
    +   public static List<Object[]> data() {
    +      return Arrays.asList(new Object[][] {
    +         {true, null},
    +         {false, null}
    +      });
    +   }
    +
    +   @Parameter(0)
    +   public boolean withExistingTable;
    +   @Parameter(1)
    +   public Object result;
    --- End diff --
    
    Your version of Junit requires to work with tuples (input, expecte result). Newer versions
allow input only. If you don't have this annotation JUnit will complain.


---

Mime
View raw message