activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1853: ARTEMIS-1663 - Add new message count an...
Date Tue, 06 Feb 2018 17:52:28 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1853#discussion_r166387479
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
---
    @@ -43,6 +44,8 @@ public PageCountPendingImpl(long queueID, long pageID, int inc) {
     
        long pageID;
     
    +   long size;
    --- End diff --
    
    There’s a difference between no size (0) and not being set (-1) the logic calculating
should be aware of this as -1 means it would need to be calculated


---

Mime
View raw message