activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1853: ARTEMIS-1663 - Add new message count an...
Date Tue, 06 Feb 2018 14:56:35 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1853#discussion_r166328137
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java
---
    @@ -53,6 +53,8 @@
     
        private Object protocolData;
     
    +   private Long messageSize;
    --- End diff --
    
    Could this be primitive? and either -1 or 0 to denote empty or not set in logic, just
objects = GC, and we're putting effort in to remove them on the hot path as much as possible
to keep GC pressure as low as possible.


---

Mime
View raw message