activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...
Date Fri, 02 Feb 2018 09:44:37 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1793#discussion_r165599007
  
    --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverter.java
---
    @@ -0,0 +1,572 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.core.protocol.openwire;
    +
    +import java.io.ByteArrayOutputStream;
    +import java.io.DataInputStream;
    +import java.io.DataOutputStream;
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.io.OutputStream;
    +import java.util.Arrays;
    +import java.util.Map;
    +import java.util.Set;
    +import java.util.Map.Entry;
    +import java.util.zip.Deflater;
    +import java.util.zip.DeflaterOutputStream;
    +import java.util.zip.Inflater;
    +import java.util.zip.InflaterInputStream;
    +import java.util.zip.InflaterOutputStream;
    +
    +import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
    +import org.apache.activemq.artemis.api.core.FilterConstants;
    +import org.apache.activemq.artemis.api.core.ICoreMessage;
    +import org.apache.activemq.artemis.api.core.SimpleString;
    +import org.apache.activemq.artemis.core.message.impl.CoreMessage;
    +import org.apache.activemq.artemis.core.message.impl.CoreMessageObjectPools;
    +import org.apache.activemq.artemis.reader.MessageUtil;
    +import org.apache.activemq.artemis.utils.DataConstants;
    +import org.apache.activemq.artemis.utils.collections.TypedProperties;
    +import org.apache.activemq.command.CommandTypes;
    +import org.apache.activemq.util.ByteArrayInputStream;
    +import org.apache.activemq.util.ByteSequence;
    +import org.apache.activemq.util.ByteSequenceData;
    +import org.apache.activemq.util.MarshallingSupport;
    +import org.fusesource.hawtbuf.UTF8Buffer;
    +
    +public class OpenWireCoreConverter {
    --- End diff --
    
    It is optional: If it won't be instantiated anymore, please make it `final` and put a
private constructor on it in order to avoid "accidental" instantiations of it


---

Mime
View raw message