From dev-return-63827-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Wed Jan 31 15:56:29 2018
Return-Path: <dev-return-63827-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id F1B78180662
	for <archive-asf-public@eu.ponee.io>; Wed, 31 Jan 2018 15:56:26 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id E1B66160C35; Wed, 31 Jan 2018 14:56:26 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 2D406160C25
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 31 Jan 2018 15:56:26 +0100 (CET)
Received: (qmail 36222 invoked by uid 500); 31 Jan 2018 14:56:25 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 36211 invoked by uid 99); 31 Jan 2018 14:56:24 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jan 2018 14:56:24 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 7309DDFD81; Wed, 31 Jan 2018 14:56:24 +0000 (UTC)
From: clebertsuconic <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1830-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1830-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1830: ARTEMIS-1644 legacy clients can't acces...
Content-Type: text/plain
Message-Id: <20180131145624.7309DDFD81@git1-us-west.apache.org>
Date: Wed, 31 Jan 2018 14:56:24 +0000 (UTC)

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1830#discussion_r165076524
  
    --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/broker.xml ---
    @@ -78,7 +78,7 @@ ${global-max-section}
              <!-- amqpLowCredits: The server will send the # credits specified at amqpCredits at this low mark -->
     
              <!-- Acceptor for every supported protocol -->
    -         <acceptor name="artemis">tcp://${host}:${default.port}?tcpSendBufferSize=1048576;tcpReceiveBufferSize=1048576;protocols=CORE,AMQP,STOMP,HORNETQ,MQTT,OPENWIRE;useEpoll=true;amqpCredits=1000;amqpLowCredits=300</acceptor>
    +         <acceptor name="artemis">tcp://${host}:${default.port}?anycastPrefix=jms.queue.;multicastPrefix=jms.topic.;tcpSendBufferSize=1048576;tcpReceiveBufferSize=1048576;protocols=CORE,AMQP,STOMP,HORNETQ,MQTT,OPENWIRE;useEpoll=true;amqpCredits=1000;amqpLowCredits=300</acceptor>
    --- End diff --
    
    this feels wrong to me.. .@mtaylor


---