From dev-return-63817-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Wed Jan 31 13:22:08 2018
Return-Path: <dev-return-63817-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id D844C180662
	for <archive-asf-public@eu.ponee.io>; Wed, 31 Jan 2018 13:22:08 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id C7FD5160C35; Wed, 31 Jan 2018 12:22:08 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 15440160C25
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 31 Jan 2018 13:22:07 +0100 (CET)
Received: (qmail 37994 invoked by uid 500); 31 Jan 2018 12:22:07 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 37982 invoked by uid 99); 31 Jan 2018 12:22:06 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jan 2018 12:22:06 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 613E2DFBC6; Wed, 31 Jan 2018 12:22:06 +0000 (UTC)
From: cshannon <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1827-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1827-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1827: Improve paged message acknowledge
Content-Type: text/plain
Message-Id: <20180131122206.613E2DFBC6@git1-us-west.apache.org>
Date: Wed, 31 Jan 2018 12:22:06 +0000 (UTC)

Github user cshannon commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1827#discussion_r165035847
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java ---
    @@ -152,14 +153,14 @@ protected void rollbackRedelivery(Transaction tx, MessageReference ref, long tim
        @Override
        public void afterCommit(final Transaction tx) {
           for (MessageReference ref : refsToAck) {
    -         synchronized (ref.getQueue()) {
    -            queue.postAcknowledge(ref);
    -         }
    +         queue.postAcknowledge(ref);
           }
     
           if (pagedMessagesToPostACK != null) {
              for (MessageReference refmsg : pagedMessagesToPostACK) {
    -            decrementRefCount(refmsg);
    --- End diff --
    
    I agree that right now it doesn't seem to be of much use except for large messages.  However if this gets taken out I would be a little concerned about introducing a future bug if other message types end up relying on this in the future.


---