From dev-return-63763-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Sat Jan 27 08:46:20 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id ECC5518065B for ; Sat, 27 Jan 2018 08:46:20 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DCB48160C51; Sat, 27 Jan 2018 07:46:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 57595160C2F for ; Sat, 27 Jan 2018 08:46:20 +0100 (CET) Received: (qmail 17108 invoked by uid 500); 27 Jan 2018 07:46:19 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 17082 invoked by uid 99); 27 Jan 2018 07:46:18 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Jan 2018 07:46:18 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 86524DFF4D; Sat, 27 Jan 2018 07:46:18 +0000 (UTC) From: graben To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis pull request #1820: [ARTEMIS-550] fix up test to validate C... Content-Type: text/plain Message-Id: <20180127074618.86524DFF4D@git1-us-west.apache.org> Date: Sat, 27 Jan 2018 07:46:18 +0000 (UTC) Github user graben commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1820#discussion_r164266537 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java --- @@ -698,8 +699,17 @@ private ActiveMQMessageConsumer createConsumer(final ActiveMQDestination dest, */ if (!response.isExists() || !response.getQueueNames().contains(dest.getSimpleAddress())) { if (response.isAutoCreateQueues()) { + SimpleString queueNameToUse = dest.getSimpleAddress(); + SimpleString addressToUse = queueNameToUse; + RoutingType routingTypeToUse = RoutingType.ANYCAST; + if (CompositeAddress.isFullyQualified(queueNameToUse.toString())) { + CompositeAddress compositeAddress = CompositeAddress.getQueueName(queueNameToUse.toString()); + addressToUse = new SimpleString(compositeAddress.getAddress()); + queueNameToUse = new SimpleString(compositeAddress.getQueueName()); + routingTypeToUse = RoutingType.MULTICAST; --- End diff -- Look at my test case in JIRA ARTEMIS-550 and you'll see that there is still a problem concerning usage of FQQN via core protocol. ---