From dev-return-63753-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Fri Jan 26 18:13:42 2018
Return-Path: <dev-return-63753-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id 8E578180657
	for <archive-asf-public@eu.ponee.io>; Fri, 26 Jan 2018 18:13:42 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 7EA26160C3E; Fri, 26 Jan 2018 17:13:42 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id EDABD160C20
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 26 Jan 2018 18:13:41 +0100 (CET)
Received: (qmail 22994 invoked by uid 500); 26 Jan 2018 17:13:41 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 22983 invoked by uid 99); 26 Jan 2018 17:13:40 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jan 2018 17:13:40 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 0FCD7E0287; Fri, 26 Jan 2018 17:13:38 +0000 (UTC)
From: michaelandrepearce <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1820-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1820-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1820: [ARTEMIS-550] fix up test to validate C...
Content-Type: text/plain
Message-Id: <20180126171339.0FCD7E0287@git1-us-west.apache.org>
Date: Fri, 26 Jan 2018 17:13:38 +0000 (UTC)

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1820#discussion_r164168395
  
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java ---
    @@ -698,8 +699,17 @@ private ActiveMQMessageConsumer createConsumer(final ActiveMQDestination dest,
                  */
                 if (!response.isExists() || !response.getQueueNames().contains(dest.getSimpleAddress())) {
                    if (response.isAutoCreateQueues()) {
    +                  SimpleString queueNameToUse = dest.getSimpleAddress();
    +                  SimpleString addressToUse = queueNameToUse;
    +                  RoutingType routingTypeToUse = RoutingType.ANYCAST;
    +                  if (CompositeAddress.isFullyQualified(queueNameToUse.toString())) {
    +                     CompositeAddress compositeAddress = CompositeAddress.getQueueName(queueNameToUse.toString());
    +                     addressToUse = new SimpleString(compositeAddress.getAddress());
    +                     queueNameToUse = new SimpleString(compositeAddress.getQueueName());
    +                     routingTypeToUse = RoutingType.MULTICAST;
    --- End diff --
    
    This is there today.


---