From dev-return-63531-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Thu Jan 18 22:22:48 2018
Return-Path: <dev-return-63531-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id 7DAF0180654
	for <archive-asf-public@eu.ponee.io>; Thu, 18 Jan 2018 22:22:48 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 6C9D5160C2B; Thu, 18 Jan 2018 21:22:48 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id AAD5D160C26
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 18 Jan 2018 22:22:47 +0100 (CET)
Received: (qmail 26578 invoked by uid 500); 18 Jan 2018 21:22:46 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 26567 invoked by uid 99); 18 Jan 2018 21:22:46 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jan 2018 21:22:46 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 5D744DFD7B; Thu, 18 Jan 2018 21:22:46 +0000 (UTC)
From: jbertram <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1781-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1781-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1781: ARTEMIS-1613 Integrating JDBC into CLI ...
Content-Type: text/plain
Message-Id: <20180118212246.5D744DFD7B@git1-us-west.apache.org>
Date: Thu, 18 Jan 2018 21:22:46 +0000 (UTC)

Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1781#discussion_r162473338
  
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java ---
    @@ -557,6 +592,25 @@ public Object run(ActionContext context) throws Exception {
              filters.put("${global-max-section}", readTextFile(ETC_GLOBAL_MAX_SPECIFIED_TXT, filters));
           }
     
    +      if (jdbc) {
    +         if (jdbcURL == null) {
    +            jdbcURL = "jdbc:derby:" + getInstance().getAbsolutePath() + "/data/derby/db;create=true";
    --- End diff --
    
    Should this be left null as well rather than defaulting to Derby?


---