From dev-return-63505-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Thu Jan 18 17:12:34 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 985FB180654 for ; Thu, 18 Jan 2018 17:12:34 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 84F54160C36; Thu, 18 Jan 2018 16:12:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CC9C3160C2B for ; Thu, 18 Jan 2018 17:12:33 +0100 (CET) Received: (qmail 60539 invoked by uid 500); 18 Jan 2018 16:12:32 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 60528 invoked by uid 99); 18 Jan 2018 16:12:32 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jan 2018 16:12:32 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5DBF3DFB8E; Thu, 18 Jan 2018 16:12:30 +0000 (UTC) From: clebertsuconic To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis pull request #1789: ARTEMIS-1619 - Add plugin support for a... Content-Type: text/plain Message-Id: <20180118161231.5DBF3DFB8E@git1-us-west.apache.org> Date: Thu, 18 Jan 2018 16:12:30 +0000 (UTC) Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1789#discussion_r162390192 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/plugin/StompPluginTest.java --- @@ -127,10 +131,33 @@ public void testSendAndReceive() throws Exception { AFTER_CREATE_SESSION, BEFORE_CLOSE_SESSION, AFTER_CLOSE_SESSION, BEFORE_CREATE_CONSUMER, AFTER_CREATE_CONSUMER, BEFORE_CLOSE_CONSUMER, AFTER_CLOSE_CONSUMER, BEFORE_CREATE_QUEUE, AFTER_CREATE_QUEUE, MESSAGE_ACKED, BEFORE_SEND, AFTER_SEND, BEFORE_MESSAGE_ROUTE, AFTER_MESSAGE_ROUTE, BEFORE_DELIVER, - AFTER_DELIVER); + AFTER_DELIVER, BEFORE_ADD_ADDRESS, AFTER_ADD_ADDRESS); + + } catch (Throwable e) { + fail(e.getMessage()); + } + + } + + @Test + public void testStompAutoCreateAddress() throws Exception { + + try { + URI uri = new URI("ws+v12.stomp://localhost:61613"); + StompClientConnection newConn = StompClientConnectionFactory.createClientConnection(uri); + newConn.connect(defUser, defPass); + + subscribeQueue(newConn, "a-sub", "autoCreated"); + + // unsub + unsubscribe(newConn, "a-sub"); + newConn.disconnect(); + + verifier.validatePluginMethodsAtLeast(1, BEFORE_ADD_ADDRESS, AFTER_ADD_ADDRESS, + BEFORE_REMOVE_ADDRESS, AFTER_REMOVE_ADDRESS); } catch (Throwable e) { - e.printStackTrace(); + fail(e.getMessage()); --- End diff -- the printStackTrace is useful when it fails :) I have been there. ---