From dev-return-63491-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Thu Jan 18 15:20:24 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id DD7C7180654 for ; Thu, 18 Jan 2018 15:20:24 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CB208160C36; Thu, 18 Jan 2018 14:20:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1D0DB160C2B for ; Thu, 18 Jan 2018 15:20:23 +0100 (CET) Received: (qmail 67609 invoked by uid 500); 18 Jan 2018 14:20:23 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 67591 invoked by uid 99); 18 Jan 2018 14:20:22 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jan 2018 14:20:22 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0A2E8DFCB5; Thu, 18 Jan 2018 14:20:22 +0000 (UTC) From: clebertsuconic To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis pull request #1787: ARTEMIS-1577 Address-settings policies ... Content-Type: text/plain Message-Id: <20180118142022.0A2E8DFCB5@git1-us-west.apache.org> Date: Thu, 18 Jan 2018 14:20:22 +0000 (UTC) Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1787#discussion_r162353710 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java --- @@ -736,11 +736,11 @@ public RoutingStatus route(final Message message, throw new IllegalStateException("Message cannot be routed more than once"); } - setPagingStore(message); + setPagingStore(context.getAddress(message), message); AtomicBoolean startedTX = new AtomicBoolean(false); - final SimpleString address = message.getAddressSimpleString(); + final SimpleString address = context.getAddress(message); --- End diff -- I'm just going for the simple refactoring here.. every call to message.getAddressSimplString() to be calling context.getAddress() ---