From dev-return-63484-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Thu Jan 18 11:31:27 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id A2010180654 for ; Thu, 18 Jan 2018 11:31:27 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 921A6160C36; Thu, 18 Jan 2018 10:31:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CFDC3160C2B for ; Thu, 18 Jan 2018 11:31:26 +0100 (CET) Received: (qmail 45295 invoked by uid 500); 18 Jan 2018 10:31:25 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 45284 invoked by uid 99); 18 Jan 2018 10:31:25 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jan 2018 10:31:25 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6E3F1DFBAA; Thu, 18 Jan 2018 10:31:25 +0000 (UTC) From: franz1981 To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis issue #1777: ARTEMIS-1606 - Change AddressInfo RoutingType ... Content-Type: text/plain Message-Id: <20180118103125.6E3F1DFBAA@git1-us-west.apache.org> Date: Thu, 18 Jan 2018 10:31:25 +0000 (UTC) Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1777 These are the flamegraph of a couple of profiled tests, one on master: ![image](https://user-images.githubusercontent.com/13125299/35093335-7394c032-fc42-11e7-862e-936863f37eff.png) Where the violet bars are the `AddressInfo::new` and the `AddressInfo::getRoutingType` (+ iterator) while with this PR: ![image](https://user-images.githubusercontent.com/13125299/35093498-d48ef4ca-fc42-11e7-81c9-04565ea66c64.png) There isn't anymore any cost associated with `AddressInfo`: for me is a thumbs up! Althouh it seems negligible (at a first look) the impact of this change has changed the garbage produced and the CPU time required to call `doSend`: indeed the latencies are better too. Well done :100: ---