From dev-return-63366-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Tue Jan 16 16:38:00 2018
Return-Path: <dev-return-63366-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id 03DF418065B
	for <archive-asf-public@eu.ponee.io>; Tue, 16 Jan 2018 16:38:00 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id E8D99160C34; Tue, 16 Jan 2018 15:37:59 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 33EB5160C26
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 16 Jan 2018 16:37:59 +0100 (CET)
Received: (qmail 50688 invoked by uid 500); 16 Jan 2018 15:37:58 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 50677 invoked by uid 99); 16 Jan 2018 15:37:57 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2018 15:37:57 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id C0434DFB0D; Tue, 16 Jan 2018 15:37:57 +0000 (UTC)
From: jbertram <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1778-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1778-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...
Content-Type: text/plain
Message-Id: <20180116153757.C0434DFB0D@git1-us-west.apache.org>
Date: Tue, 16 Jan 2018 15:37:57 +0000 (UTC)

Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1778#discussion_r161794632
  
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java ---
    @@ -273,6 +286,14 @@ public void setAddress(String address) {
           setSimpleAddress(SimpleString.toSimpleString(address));
        }
     
    +   public void setName(String name) {
    --- End diff --
    
    The address setter was added as part of an effort to make Artemis JNDI work properly in Tomcat.  I assume it's needed here, but I'll remove it for simplicity's sake and it can be added later if necessary.


---