From dev-return-63256-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Thu Jan 11 13:32:32 2018
Return-Path: <dev-return-63256-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id EF480180656
	for <archive-asf-public@eu.ponee.io>; Thu, 11 Jan 2018 13:32:31 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id DEFC9160C20; Thu, 11 Jan 2018 12:32:31 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 599E9160C1F
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 11 Jan 2018 13:32:31 +0100 (CET)
Received: (qmail 94013 invoked by uid 500); 11 Jan 2018 12:32:30 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 94002 invoked by uid 99); 11 Jan 2018 12:32:30 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jan 2018 12:32:30 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 0BC33E9622; Thu, 11 Jan 2018 12:32:30 +0000 (UTC)
From: mtaylor <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1759-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1759-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1759: [ARTEMIS-1241] check for FQQN and autoc...
Content-Type: text/plain
Message-Id: <20180111123230.0BC33E9622@git1-us-west.apache.org>
Date: Thu, 11 Jan 2018 12:32:30 +0000 (UTC)

Github user mtaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1759#discussion_r160926081
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
    @@ -2834,7 +2842,7 @@ public Queue createQueue(final SimpleString address,
              throw ActiveMQMessageBundle.BUNDLE.invalidRoutingTypeForAddress(routingType, info.getName().toString(), info.getRoutingTypes());
           }
     
    -      final QueueConfig queueConfig = queueConfigBuilder.filter(filter).pagingManager(pagingManager).user(user).durable(durable).temporary(temporary).autoCreated(autoCreated).routingType(routingType).maxConsumers(maxConsumers).purgeOnNoConsumers(purgeOnNoConsumers).build();
    +      final QueueConfig queueConfig = queueConfigBuilder.filter(filter).pagingManager(pagingManager).user(user).durable(durable).temporary(temporary).autoCreated(autoCreated).routingType(routingTypeToUse).maxConsumers(maxConsumers).purgeOnNoConsumers(purgeOnNoConsumers).build();
    --- End diff --
    
    The routing type should be decided by the protocol handler and passed in.  


---