From dev-return-63078-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Fri Jan  5 23:24:45 2018
Return-Path: <dev-return-63078-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id DD869180647
	for <archive-asf-public@eu.ponee.io>; Fri,  5 Jan 2018 23:24:45 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id CD5F2160C27; Fri,  5 Jan 2018 22:24:45 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 16DE5160C15
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  5 Jan 2018 23:24:44 +0100 (CET)
Received: (qmail 21138 invoked by uid 500); 5 Jan 2018 22:24:44 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 21126 invoked by uid 99); 5 Jan 2018 22:24:43 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2018 22:24:43 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id BB40ADFE46; Fri,  5 Jan 2018 22:24:43 +0000 (UTC)
From: michaelandrepearce <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1752-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1752-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1752: ARTEMIS-1586 Reduce GC pressure due to ...
Content-Type: text/plain
Message-Id: <20180105222443.BB40ADFE46@git1-us-west.apache.org>
Date: Fri,  5 Jan 2018 22:24:43 +0000 (UTC)

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1752#discussion_r159993639
  
    --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java ---
    @@ -329,7 +331,9 @@ public boolean containsProperty(final SimpleString key) {
           }
        }
     
    -   public synchronized void decode(final ByteBuf buffer) {
    --- End diff --
    
    its not, you removed a public method, from a very common class thats exposed to clients. 


---