From dev-return-63068-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Fri Jan  5 22:09:52 2018
Return-Path: <dev-return-63068-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id 004B6180647
	for <archive-asf-public@eu.ponee.io>; Fri,  5 Jan 2018 22:09:52 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id E40AD160C27; Fri,  5 Jan 2018 21:09:51 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 5D61A160C15
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  5 Jan 2018 22:09:51 +0100 (CET)
Received: (qmail 62613 invoked by uid 500); 5 Jan 2018 21:09:45 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 62597 invoked by uid 99); 5 Jan 2018 21:09:45 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2018 21:09:45 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 1DC30DFC3E; Fri,  5 Jan 2018 21:09:45 +0000 (UTC)
From: michaelandrepearce <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1752-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1752-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1752: ARTEMIS-1586 Reduce GC pressure due to ...
Content-Type: text/plain
Message-Id: <20180105210945.1DC30DFC3E@git1-us-west.apache.org>
Date: Fri,  5 Jan 2018 21:09:45 +0000 (UTC)

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1752#discussion_r159980786
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ServerPacketDecoder.java ---
    @@ -83,16 +85,34 @@
     
     public class ServerPacketDecoder extends ClientPacketDecoder {
     
    +   private static final int UUID_LENGTH = 36;
    +   private static final int DEFAULT_INTERNER_CAPACITY = 32;
        private static final long serialVersionUID = 3348673114388400766L;
    -   public static final ServerPacketDecoder INSTANCE = new ServerPacketDecoder();
    +   private SimpleString.Interner keysInterner;
    +   private TypedProperties.StringValue.Interner valuesInterner;
     
    -   private static SessionSendMessage decodeSessionSendMessage(final ActiveMQBuffer in, CoreRemotingConnection connection) {
    +   public ServerPacketDecoder() {
    +      this.keysInterner = null;
    +      this.valuesInterner = null;
    +   }
    +
    +   private void initializeInternersIfNeeded() {
    --- End diff --
    
    one interner per session :O ouch - an interner ideally should be shared within JVM so benefits can be reaped anywhere.


---