activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dwickern <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1826: fix ARTEMIS_HOME check in Windows batch...
Date Tue, 30 Jan 2018 19:49:08 GMT
GitHub user dwickern opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1826

    fix ARTEMIS_HOME check in Windows batch script

    The batch script makes an attempt to detect `ARTEMIS_HOME`:
    ```bat
    PUSHD .
    CD %~dp0..
    set ARTEMIS_HOME="%CD%"
    POPD
    ```
    
    This doesn't work because `%CD%` doesn't update when changing to a new directory. Here's
the output from the above code with echo on:
    ```
    C:\Users\dwickern>PUSHD .
    C:\Users\dwickern>CD Z:\activemq\apache-artemis-2.4.0\bin\..
    C:\Users\dwickern>set ARTEMIS_HOME="C:\Users\dwickern"
    C:\Users\dwickern>POPD
    ```
    
    I guess the original code tried to resolve the absolute path but it seems to work fine
with relative paths.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dwickern/activemq-artemis fix-windows-home-check

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1826.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1826
    
----
commit 2653a9d898a7946568177337cb4e1cf225cf187f
Author: Derek Wickern <dwickern@...>
Date:   2018-01-30T19:34:13Z

    fix ARTEMIS_HOME check in Windows batch script

----


---

Mime
View raw message