activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cshannon <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1827: Improve paged message acknowledge
Date Wed, 31 Jan 2018 12:22:06 GMT
Github user cshannon commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1827#discussion_r165035847
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java
---
    @@ -152,14 +153,14 @@ protected void rollbackRedelivery(Transaction tx, MessageReference
ref, long tim
        @Override
        public void afterCommit(final Transaction tx) {
           for (MessageReference ref : refsToAck) {
    -         synchronized (ref.getQueue()) {
    -            queue.postAcknowledge(ref);
    -         }
    +         queue.postAcknowledge(ref);
           }
     
           if (pagedMessagesToPostACK != null) {
              for (MessageReference refmsg : pagedMessagesToPostACK) {
    -            decrementRefCount(refmsg);
    --- End diff --
    
    I agree that right now it doesn't seem to be of much use except for large messages.  However
if this gets taken out I would be a little concerned about introducing a future bug if other
message types end up relying on this in the future.


---

Mime
View raw message