activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1819: ARTEMIS-1639 HornetQClientProtocolManag...
Date Fri, 26 Jan 2018 16:58:54 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1819#discussion_r164164806
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/remoting/compat/HQClientProtocolManagerTest.java
---
    @@ -0,0 +1,104 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.tests.integration.remoting.compat;
    +
    +import org.apache.activemq.artemis.api.core.ActiveMQException;
    +import org.apache.activemq.artemis.api.core.Interceptor;
    +import org.apache.activemq.artemis.api.core.SimpleString;
    +import org.apache.activemq.artemis.api.core.client.ClientSession;
    +import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
    +import org.apache.activemq.artemis.api.core.client.ServerLocator;
    +import org.apache.activemq.artemis.core.client.impl.ClientSessionInternal;
    +import org.apache.activemq.artemis.core.protocol.core.Packet;
    +import org.apache.activemq.artemis.core.protocol.core.impl.PacketImpl;
    +import org.apache.activemq.artemis.core.protocol.hornetq.client.HornetQClientProtocolManagerFactory;
    +import org.apache.activemq.artemis.core.server.ActiveMQServer;
    +import org.apache.activemq.artemis.spi.core.protocol.RemotingConnection;
    +import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
    +import org.junit.Test;
    +
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Set;
    +
    +public class HQClientProtocolManagerTest extends ActiveMQTestBase {
    --- End diff --
    
    Can you write a test using the new compatibility test framework instead?
    
    it would be nice to do a simple failover of hornetq client, artemis 1.x and artemis 2.x
to see if there's any further issues.


---

Mime
View raw message