activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1796: ARTEMIS-1623 ActiveMQServerPlugin impl for log...
Date Mon, 22 Jan 2018 17:05:58 GMT
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1796
  
    Couple of things:
    
    - Nice work!
    - It's not clear to me why some things are logged at DEBUG vs. INFO.  Perhaps the documentation
could address this.
    - Since you're using the "f" logging method variants it's really not necessary to do the
isXEnabled() check before logging since those methods do that check already.
    - In the places where you're logging either DEBUG or INFO and the format is the same you
can use `org.jboss.logging.Logger#logf` and just pass in the level you want to use so you
don't have duplicated code.


---

Mime
View raw message