activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gaohoward <>
Subject [GitHub] activemq-artemis issue #1800: ARTEMIS-1626 Disable thread leak check for fai...
Date Mon, 22 Jan 2018 16:16:22 GMT
Github user gaohoward commented on the issue:
    @clebertsuconic I don't think the PR make the debugging of thread leaking harder.
    For example suppose we have 3 tests, test1, test2 and test3 running in this order.
    Let's say test1 passes and test2 fails. You can be sure test2 is not caused by leaking
threads from test1, because test1 passes and the thread checking rule is enabled on it.
    So you just need to fix test2 (in which thread leaking factor is ruled out).
    This is the same as before (without this PR), but the tests will be finished 60 second
    This is good when  a PR is submitted and Jenkins starts a job. If the PR causes any failure,
    jenkins will finish faster and the PR owner will quickly get the report and starting investigate.
    Does that make sense? 


View raw message