activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1777: ARTEMIS-1606 - Change AddressInfo RoutingType ...
Date Thu, 18 Jan 2018 10:31:25 GMT
Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1777
  
    These are the flamegraph of a couple of profiled tests, one on master:
    ![image](https://user-images.githubusercontent.com/13125299/35093335-7394c032-fc42-11e7-862e-936863f37eff.png)
    Where the violet bars are the `AddressInfo::new` and the `AddressInfo::getRoutingType`
(+ iterator) while with this PR:
    ![image](https://user-images.githubusercontent.com/13125299/35093498-d48ef4ca-fc42-11e7-81c9-04565ea66c64.png)
    There isn't anymore any cost associated with `AddressInfo`: for me is a thumbs up!
    Althouh it seems negligible (at a first look) the impact of this change has changed the
garbage produced and the CPU time required to call `doSend`: indeed the latencies are better
too.
    Well done :100: 


---

Mime
View raw message