activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1771: ARTEMIS-1600 Support masked passwords i...
Date Wed, 17 Jan 2018 19:00:00 GMT
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1771#discussion_r162146958
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java
---
    @@ -622,8 +622,8 @@ public static String getDefaultClusterPassword() {
        /**
         * This option controls whether passwords in server configuration need be masked.
If set to "true" the passwords are masked.
         */
    -   public static boolean isDefaultMaskPassword() {
    -      return DEFAULT_MASK_PASSWORD;
    +   public static Boolean isDefaultMaskPassword() {
    --- End diff --
    
    @clebertsuconic, check out org.apache.activemq.artemis.utils.PasswordMaskingUtil.resolveMask.
 I believe the way that method works is why he needs 3 values.


---

Mime
View raw message