activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...
Date Wed, 17 Jan 2018 08:11:09 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1778#discussion_r161979093
  
    --- Diff: tests/compatibility-tests/src/main/resources/serial/jbmserial.groovy ---
    @@ -49,6 +50,11 @@ if (method.equals("write")) {
         topic = new ActiveMQTopic("topic")
         temporary = ActiveMQDestination.createTemporaryQueue("whatever")
         temporaryTopic = ActiveMQDestination.createTemporaryTopic("whatever")
    +    if (version.equals("ARTEMIS-SNAPSHOT")) {
    +        destination = new ActiveMQDestination("address", "name", ActiveMQDestination.TYPE.DESTINATION,
null)
    --- End diff --
    
    Same as other comment, for 2.x this really should be using the non "name" constructor
this constructor should be deprecated.


---

Mime
View raw message