activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...
Date Wed, 17 Jan 2018 08:09:15 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1778#discussion_r161978767
  
    --- Diff: tests/compatibility-tests/src/main/resources/serial/serial.groovy ---
    @@ -24,30 +24,40 @@ import org.apache.activemq.artemis.jms.client.*
     
     file = arg[0]
     method = arg[1]
    -System.out.println("File::" + file);
    +version = arg[2]
    +System.out.println("File::" + file)
     
     
     if (method.equals("write")) {
         cf = new ActiveMQConnectionFactory("tcp://localhost:61616?confirmationWindowSize=1048576&blockOnDurableSend=false");
         queue = new ActiveMQQueue("queue");
         topic = new ActiveMQTopic("topic")
    +    if (version.equals("ARTEMIS-SNAPSHOT")) {
    +        destination = new ActiveMQDestination("address", "name", ActiveMQDestination.TYPE.DESTINATION,
null)
    --- End diff --
    
    I dont think we should be creating ActiveMQDestination with "name" in 2.X this constructor
should be deprecated, the "name" is only for compatibility with older client version.


---

Mime
View raw message