activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...
Date Tue, 16 Jan 2018 19:51:22 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1778#discussion_r161868236
  
    --- Diff: tests/compatibility-tests/src/main/resources/serial/serial.groovy ---
    @@ -24,30 +24,46 @@ import org.apache.activemq.artemis.jms.client.*
     
     file = arg[0]
     method = arg[1]
    -System.out.println("File::" + file);
    +version = arg[2]
    +System.out.println("File::" + file)
     
     
     if (method.equals("write")) {
         cf = new ActiveMQConnectionFactory("tcp://localhost:61616?confirmationWindowSize=1048576&blockOnDurableSend=false");
         queue = new ActiveMQQueue("queue");
         topic = new ActiveMQTopic("topic")
    +    if (version.equals("ARTEMIS-SNAPSHOT")) {
    +        destination = new ActiveMQDestination("address", "name", ActiveMQDestination.TYPE.DESTINATION,
null)
    +    } else if (version.equals("ARTEMIS-155")) {
    +        destination = new ActiveMQDestination("address", "name", false, true, null)
    +    }
     
         ObjectOutputStream objectOutputStream = new ObjectOutputStream(new FileOutputStream(file));
         objectOutputStream.writeObject(cf);
         objectOutputStream.writeObject(queue)
         objectOutputStream.writeObject(topic)
    +    if (version.startsWith("ARTEMIS")) {
    +        objectOutputStream.writeObject(destination)
    +    }
         objectOutputStream.close();
     } else {
         ObjectInputStream inputStream = new ObjectInputStream(new FileInputStream(file))
     
         cf = inputStream.readObject();
         queue = inputStream.readObject()
         topic = inputStream.readObject()
    +    if (version.startsWith("ARTEMIS")) {
    +        destination = inputStream.readObject()
    +    }
         inputStream.close();
     }
     
     GroovyRun.assertTrue(!cf.getServerLocator().isBlockOnDurableSend());
    -GroovyRun.assertEquals(1048576, cf.getServerLocator().getConfirmationWindowSize());
    +GroovyRun.assertEquals(1048576, cf.getServerLocator().getConfirmationWindowSize())
    +if (version.startsWith("ARTEMIS")) {
    --- End diff --
    
    you don't need that if ^^^


---

Mime
View raw message